fix(dec-20-audit): [H01] fix optimistic oracle fee burning logic when final fee == 0#2429
Merged
mrice32 merged 3 commits intoUMAprotocol:masterfrom Jan 20, 2021
Merged
fix(dec-20-audit): [H01] fix optimistic oracle fee burning logic when final fee == 0#2429mrice32 merged 3 commits intoUMAprotocol:masterfrom
mrice32 merged 3 commits intoUMAprotocol:masterfrom
Conversation
… fee == 0 Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenZeppelin pointed out an issue in the H01 fix. In the (admittedly unlikely) case that the final fee is 0, the burned portion of the bond gets trapped in the optimistic oracle contract and can never be retrieved.
Summary
This fixes the issue by conditioning the payout on the sum of the burned bond and the final fee being > 0, which was the original intention of the code.
Issue(s)
N/A