Navigation to diff view from description page #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rebornix
commented
Dec 11, 2018
•
rebornix
commented
rebornix
changed the title
RMacfarlane
reviewed
Dec 12, 2018
| context.subscriptions.push(vscode.commands.registerCommand('pr.openDescription', async (pr: IPullRequestModel) => { | ||
| const pullRequest = ensurePR(prManager, pr); | ||
| context.subscriptions.push(vscode.commands.registerCommand('pr.openDescription', async (descriptionNode: DescriptionNode) => { | ||
| const pullRequest = ensurePR(prManager, descriptionNode.pullRequestModel); |
There was a problem hiding this comment.
when opening the description from the command palette or the status bar, descriptionNode can be undefined
|
Added outdated label to comment reviews and we don't support code navigation if the comment is outdated.
|
RMacfarlane
reviewed
Dec 13, 2018
| const diffPath: HTMLSpanElement = document.createElement('span'); | ||
| diffPath.className = outdated ? 'diffPath outdated' : 'diffPath'; | ||
| diffPath.textContent = comments[0].path; | ||
| diffPath.addEventListener('click', () => this.openDiff(comments[0])); |
There was a problem hiding this comment.
should the event listener only be added if the comment isn't outdated?
RMacfarlane
reviewed
Dec 13, 2018
| if ((prContainer as TreeNode | Revealable<TreeNode>).revealComment) { | ||
| (prContainer as TreeNode | Revealable<TreeNode>).revealComment(comment); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
log something to debug if reveal fails?
RMacfarlane
reviewed
Dec 13, 2018
| @@ -591,11 +591,24 @@ class ReviewNode { | |||
| }); | |||
| } | |||
|
|
|||
| let outdated = comments[0].position !== comments[0].original_position; | |||
There was a problem hiding this comment.
in other places we check if position is null to determine if a comment is outdated. I think we should do that here too
|
@RMacfarlane comments addressed ;) |
RMacfarlane
approved these changes
Jan 4, 2019
…iffhunk-from-descriptionview
…iffhunk-from-descriptionview
RMacfarlane
deleted the
rebornix/navigate-diffhunk-from-descriptionview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.